Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues for purestorage solution offer #10120

Merged
merged 7 commits into from
Mar 12, 2024

Conversation

skeerthivasan
Copy link
Contributor

Required items, please complete

Change(s):
Initial Solution release for Pure Storage

Reason for Change(s):
Adding Parser only solution package for PureStorage

Version Updated:
No - First release

Testing Completed:
Yes

Checked that the validations are passing and have addressed any issues that are present:
Yes

@skeerthivasan skeerthivasan requested review from a team as code owners March 11, 2024 09:02
@v-atulyadav v-atulyadav self-assigned this Mar 11, 2024
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Mar 11, 2024
@@ -1,6 +1,6 @@
{
"publisherId": "purestorageinc1707205060945",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @skeerthivasan,
In your partner center we have seen purestoragemarketplaceadmin publisherid. Please replace this and repackage again. Thanks

@v-atulyadav
Copy link
Contributor

Hi @skeerthivasan,
Please repackage this solution with the help of below link. Thanks
Azure-Sentinel/Tools/Create-Azure-Sentinel-Solution/V3/README.md at master · Azure/Azure-Sentinel (github.com)

@skeerthivasan
Copy link
Contributor Author

Hi @skeerthivasan, Please repackage this solution with the help of below link. Thanks Azure-Sentinel/Tools/Create-Azure-Sentinel-Solution/V3/README.md at master · Azure/Azure-Sentinel (github.com)

@v-atulyadav , I have repackaged and pushed it again, but I see few validations are failed, can we restart the check again ? or Am I missing something ?

@skeerthivasan
Copy link
Contributor Author

@v-atulyadav , I have pushed it again, checks are fine now. Please check and proceed

@skeerthivasan
Copy link
Contributor Author

@v-atulyadav , I see you have repackaged it, below 'steps' line should be [], instead of null. This would cause issue during package upload in solution offer. Let me know your thoughts on this.
ee4672e#diff-1386cca6740fbce10529e79de2fb77a84307add596cbd654fbeba11f2fa9d4aeR53

@v-atulyadav v-atulyadav merged commit afb3be6 into Azure:master Mar 12, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants